-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request previous IP address in discovery #10098
Conversation
14317c5
to
2550777
Compare
"make conformance" said "openpgp: signature made by unknown entity" about my GitHub-created commit. No idea how to fix that. I tried to "make iso", but I got "Error response from daemon: manifest unknown", so I can't test this. |
Rebased, re-signed, marked as ready for review. |
This ensures that even in the event of a DHCP downtime that exceeds the lease time, the current IP can be maintained. Signed-off-by: TomyLobo <[email protected]> Signed-off-by: Andrey Smirnov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, I applied some (sometimes unrelated) fixes as well
I tested this manually by making our test DHCP server send random NAKs to the request messages:
|
/m |
Pull Request
What? (description)
Hopefully fixes #10086
Why? (reasoning)
Acceptance
Please use the following checklist:
make conformance
)make fmt
)make lint
)make docs
)make unit-tests
)