refactor: extract platform metadata into Talos machinery #10173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unix4ever
approved these changes
Jan 20, 2025
frezbo
reviewed
Jan 20, 2025
|
|
||
| // NotOnlyDiskImage is true if the platform supports boot methods other than disk-image. | ||
| func (p Platform) NotOnlyDiskImage() bool { | ||
| if len(p.BootMethods) == 1 && p.BootMethods[0] == BootMethodDiskImage { |
There was a problem hiding this comment.
is the BootMethods slice deterministic?, since MetalPlatform has pxe as the first boot method, shouldn't the second condition be slices.Contains?
There was a problem hiding this comment.
This method basically checks BootMethods != {BootMethodDiskImage}, it has nothing to do with the order specifically.
If only disk image is used, we can skip installer.
frezbo
approved these changes
Jan 20, 2025
It will be used across Image Factory, Terraform Provider and Omni. Fixes siderolabs#10108 See siderolabs/image-factory#189 Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
refactor/platform-metadata
branch
from
9c96052 to
e1efbf6
Compare
|
/m |
smira
added a commit
to smira/terraform-provider-talos
that referenced
this pull request
Jan 20, 2025
See siderolabs/talos#10173 Signed-off-by: Andrey Smirnov <[email protected]>
smira
added a commit
to smira/terraform-provider-talos
that referenced
this pull request
Jan 20, 2025
See siderolabs/talos#10173 Signed-off-by: Andrey Smirnov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be used across Image Factory, Terraform Provider and Omni.
Fixes #10108
See siderolabs/image-factory#189