fix: abort node watch on hostname change #10175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
approved these changes
Jan 20, 2025
DmitriyMV
reviewed
Jan 20, 2025
internal/app/machined/pkg/controllers/k8s/internal/nodewatch/nodewatch.go
Show resolved
Hide resolved
DmitriyMV
reviewed
Jan 20, 2025
DmitriyMV
approved these changes
Jan 20, 2025
smira
force-pushed
the
fix/k8s-node-status
branch
from
8252dca to
08d1f81
Compare
The method `WaitForCacheSync` might block for a long time, and looks like it can block forever if the nodename requested doesn't match the actual nodename. Allow the wait to be aborted by running it in a goroutine, and notifying readiness of the watcher via the `notifyCh`. Fixes siderolabs#10163 Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
fix/k8s-node-status
branch
from
00c0d7e to
0b7fc7c
Compare
|
/m |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
WaitForCacheSyncmight block for a long time, and looks like it can block forever if the nodename requested doesn't match the actual nodename.Allow the wait to be aborted by running it in a goroutine, and notifying readiness of the watcher via the
notifyCh.Fixes #10163