Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored the PackageUploadHelper class on Artifactory Uploader #247

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

crvreddy
Copy link
Collaborator

@crvreddy crvreddy commented Feb 4, 2025

Added new PackageUploadInformation class.All package upload information methods moved to this class.
Refactored switch case methods in arifactory uploader and package creater

@adityanarayanp adityanarayanp self-assigned this Feb 4, 2025
@adityanarayanp adityanarayanp added enhancement New feature or request Importance Low Minor Impact labels Feb 4, 2025
@adityanarayanp adityanarayanp added this to the 8.0.0 milestone Feb 4, 2025
@adityanarayanp adityanarayanp added the Refactoring Improving code structure, readability, and maintainability without changing functionality label Feb 4, 2025
@crvreddy crvreddy changed the title Refactored the PackageUploadHelper class Refactored the PackageUploadHelper class on Artifactory Uploader Feb 4, 2025
Copy link
Contributor

@adityanarayanp adityanarayanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we refactor the PackageUploadHelper more to move it still has a lot of packages, could we seperate it out logically to different classes

Copy link
Contributor

@adityanarayanp adityanarayanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is not calling the new helper

if (SetWarningCode)
{
PipelineArtifactUploader.UploadArtifacts();
Environment.ExitCode = 2;
Logger.Debug("Setting ExitCode to 2");
}

@adityanarayanp adityanarayanp self-requested a review February 5, 2025 14:08
@crvreddy crvreddy requested a review from sumanthkb44 February 7, 2025 12:28
@crvreddy crvreddy merged commit 51144f7 into development Feb 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Importance Low Minor Impact Refactoring Improving code structure, readability, and maintainability without changing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants