-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored the PackageUploadHelper class on Artifactory Uploader #247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we refactor the PackageUploadHelper more to move it still has a lot of packages, could we seperate it out logically to different classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this is not calling the new helper
if (SetWarningCode)
{
PipelineArtifactUploader.UploadArtifacts();
Environment.ExitCode = 2;
Logger.Debug("Setting ExitCode to 2");
}
Added new PackageUploadInformation class.All package upload information methods moved to this class.
Refactored switch case methods in arifactory uploader and package creater