fix: libpod API perf issue due to using /info instead of /_ping (#40) #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thediveo
commented
Jan 18, 2024
thediveo
commented
- test: log list-network timing for Docker, podman
- perf: don't use /info libpod endpoint for API version detection, as it is very slow
- fix: use _ping endpoint for libpod API version detection
- chore: refactoring
- fix: podmannet test failing on Ubuntu 22.04LTS
* test: log list-network timing for Docker, podman Signed-off-by: thediveo <[email protected]> * perf: don't use /info libpod endpoint for API version detection, as it is very slow Signed-off-by: thediveo <[email protected]> * fix: use _ping endpoint for libpod API version detection Signed-off-by: thediveo <[email protected]> * chore: refactoring Signed-off-by: thediveo <[email protected]> * fix: podmannet test failing on Ubuntu 22.04LTS Signed-off-by: thediveo <[email protected]> --------- Signed-off-by: thediveo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.