-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use syntect to highlight #99
base: master
Are you sure you want to change the base?
Conversation
I used to use syntect before but I replaced it with custom parsing because it's simpler even faster and have no compile time repercussion But I like the idea but I prefer:
|
I remember the performance was a real issue (that code gets executed on each key stroke) not sure if things has improved |
add three features, TODO:
anything else? |
I made a demo comparing the two: (I just copy a large text and hit shift ctrl v) You can see that I can't even wait for syntect to finish xD Admittedly the difference is less in release mode, also the pasting can be improved by using bracketed paste terminal event but that's another issue. |
btw I just added some new feature requests ideas https://github.com/sigmaSd/IRust/issues if you're interested. Also feel free to add more if you want. |
Improved the highlight performance. If this is acceptable, I'll begin to add theme support. |
Nice , unfortunately now you are dealing with the very ugly parts of the codebase Hopefully we can make it work though, I'll have to test for a bit |
I added another commit which seems to fix the 2 positioning problems. But that probably need more testing |
I finally got around to adding benchmarks a7c0194 (I added them to my own fork) And the number difference is huge |
oh well I guess that commit should be reverted and can be something to fix in a later time I tested on linux wezterm |
Try using syntect to highlight, any ideas?