Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace union member CSS with any to speed up type checking massively. #1

Open
wants to merge 9 commits into
base: canary
Choose a base branch
from
+372 −371
Open

Replace union member CSS with any to speed up type checking massively. #1

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3a768e0
Replace union member CSS with any to speed up type checking massively.
Oct 23, 2023
386209b
Update package.json name to allow publishing private fork.
Oct 25, 2023
0fe7695
v1.3.1-3
Oct 25, 2023
4f87d73
Replace all @stitches/(\w+) with @sigmacomputing/stitches-$1
Oct 25, 2023
6bdc093
v1.3.1-4
Oct 25, 2023
7b3c27a
Revert "Replace union member CSS with any to speed up type checking m…
Nov 21, 2023
41e14d1
Revert "v1.3.1-4"
Nov 21, 2023
ca68309
1.3.1-7
Nov 21, 2023
2602ca0
Set access to restricted for our fork
Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/types/css-util.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ export type CSS<
[K: string]: (
| number
| string
| CSS<Media, Theme, ThemeMap, Utils>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that we lose type completion on nested css objects/properties?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an example where that would apply? I think line 30's member should handle most properties.

Copy link

@Pearce-Ropion Pearce-Ropion Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im talking about the nested case. Line 30 handles properties at the top of the object. I think the line you are removing handles all the nested properties.

Screenshot 2023-10-25 at 1 10 04 PM

| {}
| undefined
| any
)
}
)
Expand Down