Skip to content

Commit

Permalink
Use camel casing for entry position field on key transparency monitor…
Browse files Browse the repository at this point in the history
… requests
  • Loading branch information
katherine-signal authored Jan 14, 2025
1 parent d3d68c2 commit 2f51778
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -151,21 +151,21 @@ public KeyTransparencyMonitorResponse monitor(
try {
final AciMonitorRequest aciMonitorRequest = AciMonitorRequest.newBuilder()
.setAci(ByteString.copyFrom(request.aci().value().toCompactByteArray()))
.setEntryPosition(request.aci().entry_position())
.setEntryPosition(request.aci().entryPosition())
.setCommitmentIndex(ByteString.copyFrom(request.aci().commitmentIndex()))
.build();

final Optional<UsernameHashMonitorRequest> usernameHashMonitorRequest = request.usernameHash().map(usernameHash ->
UsernameHashMonitorRequest.newBuilder()
.setUsernameHash(ByteString.copyFrom(usernameHash.value()))
.setEntryPosition(usernameHash.entry_position())
.setEntryPosition(usernameHash.entryPosition())
.setCommitmentIndex(ByteString.copyFrom(usernameHash.commitmentIndex()))
.build());

final Optional<E164MonitorRequest> e164MonitorRequest = request.e164().map(e164 ->
E164MonitorRequest.newBuilder()
.setE164(e164.value())
.setEntryPosition(e164.entry_position())
.setEntryPosition(e164.entryPosition())
.setCommitmentIndex(ByteString.copyFrom(e164.commitmentIndex()))
.build());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import jakarta.validation.constraints.NotEmpty;
import jakarta.validation.constraints.NotNull;
import jakarta.validation.constraints.Positive;
import java.util.List;
import java.util.Optional;
import org.whispersystems.textsecuregcm.identity.AciServiceIdentifier;
import org.whispersystems.textsecuregcm.util.ByteArrayAdapter;
Expand Down Expand Up @@ -51,7 +50,7 @@ public record AciMonitor(

@Schema(description = "A log tree position maintained by the client for the aci.")
@Positive
long entry_position,
long entryPosition,

@Schema(description = "The commitment index derived from a previous search request, encoded in standard unpadded base64")
@JsonSerialize(using = ByteArrayAdapter.Serializing.class)
Expand All @@ -68,7 +67,7 @@ public record E164Monitor(

@Schema(description = "A log tree position maintained by the client for the e164.")
@Positive
long entry_position,
long entryPosition,

@Schema(description = "The commitment index derived from a previous search request, encoded in standard unpadded base64")
@JsonSerialize(using = ByteArrayAdapter.Serializing.class)
Expand All @@ -89,7 +88,7 @@ public record UsernameHashMonitor(

@Schema(description = "A log tree position maintained by the client for the username hash.")
@Positive
long entry_position,
long entryPosition,

@Schema(description = "The commitment index derived from a previous search request, encoded in standard unpadded base64")
@JsonSerialize(using = ByteArrayAdapter.Serializing.class)
Expand Down

0 comments on commit 2f51778

Please sign in to comment.