Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update podspec allow other platforms #513

Conversation

EddieLukeAtmey
Copy link

resolve #512

@jrose-signal
Copy link
Contributor

jrose-signal commented Feb 15, 2023

Thanks, but there's a little more than just that: you can see in the build settings section that we have to do a manual translation to Rust target names based on the platform and architecture. There are already names for macOS set up, so that should work in theory, but tvOS and watchOS should probably be subsetted out, at least for now.

I'm also realizing that LibSignalClient depends on SignalCoreKit, which doesn't declare support for macOS either, but I think that's mostly just for logging, so maybe that dependency can be moved to a subspec. (EDIT: I missed that you sent a PR to SignalCoreKit as well.)

I suggest testing this locally to make sure it all works, i.e. pod lib lint --platforms=macos should in theory pass once you've built the Rust FFI library.

@stale
Copy link

stale bot commented May 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 16, 2023
@stale
Copy link

stale bot commented May 24, 2023

This issue has been closed due to inactivity.

@stale stale bot closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

[Swift][Pod] Add macOS support
2 participants