Add disk buffering config options to RUM conf #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
srv-gh-o11y-gdi-cla
added a commit
to splunk/cla-agreement
that referenced
this pull request
Oct 18, 2023
breedx-splk
reviewed
Oct 18, 2023
breedx-splk
approved these changes
Oct 18, 2023
pellared
approved these changes
Oct 19, 2023
|
@signalfx/gdi-ios-maintainers, FYI |
Kielek
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently iOS and android have different config options for enabling and configuring disk buffering.
Android
enableDiskBuffering
limitDiskUsageMegabytes
iOS
enableDiskCache
spanDiskCacheMaxSize
Also react native needs to use the same conf. After discussions it seems "buffering" makes more sense so let's use android version. Not sure where to put mobile only conf options put them into the same table.