Update telemetry resource attributes #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
pellared
reviewed
Oct 23, 2023
|
I have read the CLA Document and I hereby sign the CLA |
srv-gh-o11y-gdi-cla
added a commit
to splunk/cla-agreement
that referenced
this pull request
Oct 24, 2023
pellared
approved these changes
Oct 24, 2023
lachmatt
approved these changes
Oct 24, 2023
akubik-splunk
approved these changes
Oct 25, 2023
mateuszrzeszutek
approved these changes
Oct 25, 2023
breedx-splk
approved these changes
Oct 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267.
Adjust our requirements to open-telemetry/semantic-conventions#178
splunk.distro.version, - As it can be replaced bytelemetry.auto.versionandtelemetry.distro.name.telemetry.auto.versiontotelemetry.distro.version, - technically not a breaking change, as it was marked as SHOULDtelemetry.distro.nameresource attribute. - new attribute, not breaking change