Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use existing peer count metrics loop to check for open_nat toggle #6800

Open
wants to merge 7 commits into
base: unstable
Choose a base branch
from
Open

Use existing peer count metrics loop to check for open_nat toggle #6800

wants to merge 7 commits into from
+43 −3

Conversation

jking-aus
Copy link
Collaborator

@jking-aus jking-aus commented Jan 13, 2025 •
edited
Loading

Issue Addressed

This addresses issue #6683

Proposed Changes

  • Add helper functions to peerinfo to get ip4 and ip6 inbound connections
  • Add threshold of 3 connections to determine if NAT is open to peer manager
  • Add update nat_open function when updating peer_count_metrics

@jking-aus jking-aus requested a review from AgeManning January 13, 2025 22:32
@jking-aus jking-aus changed the title Use peerdb to determine if libp2p nat_open metric should be toggled Use existing peer count metrics loop to check for open_nat toggle Jan 14, 2025
@jking-aus jking-aus marked this pull request as ready for review January 14, 2025 04:30
@jking-aus jking-aus requested a review from jxs as a code owner January 14, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgeManning AgeManning Awaiting requested review from AgeManning

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jking-aus