Couple the send_queue more closely with connected peers #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is difficult to reason about handler send queues and if in fact they are always in sync with the connected_peer mappings.
This shifts the send-queues inside the connected_peers mapping to ensure that if there is a connected peer, then it should have a send_queue.
This prevents any kind of panics that may arise if the send-queue mapping is out of sync with the connected peer mapping. There may still be panics if the connected_peer list is out of sync with mesh or topic mappings, however that is out of scope of this PR.
As gossipsub has been running for a while, we assume the above mappings are correct.