-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pages publishing to root-signing-staging #398
Add Pages publishing to root-signing-staging #398
Conversation
This requires support for "workflow" build type Signed-off-by: Jussi Kukkonen <[email protected]>
🍹
|
hmm, this shows no pending changes, i guess this is to be expected? |
It is weird... Because I used to have this configured manually in root-signing-staging but the previous "pulumi up" from this repo undid my manual changes. So I did expect this to do changes. |
Actually, I think my github-sync patch is missing the line that applies the changes. Marking draft for now, thanks for double checking |
Added a further fix in github-sync: sigstore/github-sync#123 EDIT: fix is now in, thanks Hayden. I can't re-run the preview so I will try close-reopen (that usually retriggers checks) |
Ok, preview looks pretty good now. (the custom role removal is just because this branch is not based on tip of current tree and is missing #395). That looks totally correct to me but I can rebase if requested. |
the actual run is still unsuccessful because of the custom role not working: #400 will unblock |
This requires support for "workflow" build type (see sigstore/github-sync#122)