Expose the deployment strategy values for the policy controller #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shearn89
force-pushed
the
feature/support-deployment-values-for-policy-controlle-webhook
branch
2 times, most recently
from
30f3e6e
to
711f9e6
Compare
|
can you rebase and sign the dco? |
|
@shearn89 thanks for adding this feature. Could you do the necessary to get this merged please? |
|
Sorry, it's been busy at work and home. I'll try to get this ready for merging soon. |
Prior to this change, the policy controller webhook was not able to have its deployment strategy modified. If you only deployed a single replica, it could not perform a rolling update due to the default `maxSurge: 25%` being rounded down to 0. This change exposes those values, so that the `maxSurge` can be updated and a single instance can be rolled. Fixes sigstore#748. Signed-off-by: Alex Shearn <[email protected]>
Signed-off-by: Alex Shearn <[email protected]>
Signed-off-by: Alex Shearn <[email protected]>
shearn89
force-pushed
the
feature/support-deployment-values-for-policy-controlle-webhook
branch
from
711f9e6
to
8e8d223
Compare
Signed-off-by: Alex Shearn <[email protected]>
|
Okay - rebased, updated, linted, schema generated, and commits signed off! If you'd like me to squash the commits or squash-merge, let me know. 😁 |
cpanato
requested changes
Oct 10, 2024
| {{- if .Values.deployment.strategy }} | ||
| strategy: | ||
| {{ toYaml .Values.deployment.strategy | trim | indent 4 }} | ||
| {{ if eq .Values.deployment.strategy.type "Recreate" }}rollingUpdate: null{{ end }} |
There was a problem hiding this comment.
let's default for the default value when you not set this field, and drop the {{- if .Values.deployment.strategy }} i dont think we need to add any extra complexity for this
There was a problem hiding this comment.
Okay - think I've done that although my templating knowledge is not amazing!
Signed-off-by: Alex Shearn <[email protected]>
…-controlle-webhook Signed-off-by: Alex Shearn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Prior to this change, the policy controller webhook was not able to have its deployment strategy modified. If you only deployed a single replica, it could not perform a rolling update due to the default
maxSurge: 25%being rounded down to 0.This change exposes those values, so that the
maxSurgecan be updated and a single instance can be rolled.Existing or Associated Issue(s)
Fixes #748.
Additional Information
Checklist
Lint output: