renaming macos to Darwin #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: greg pereira <[email protected]>
mihaimaruseac
requested changes
May 16, 2024
This should not be changed, |
|
My appologies, seems I missunderstood what you were saying, I will update the filenames in the workflows. |
Signed-off-by: greg pereira <[email protected]>
Gregory-Pereira
force-pushed
the
swap-macOS-for-Darwin
branch
from
e3e2500
to
f00b80a
Compare
|
/cc @mihaimaruseac @smeiklej Do tests require approval to run? Trying to test the workflow changes requested |
|
They do, yes. |
Signed-off-by: greg pereira <[email protected]>
Gregory-Pereira
force-pushed
the
swap-macOS-for-Darwin
branch
7 times, most recently
from
5273505
to
a604f5a
Compare
Signed-off-by: greg pereira <[email protected]>
Gregory-Pereira
force-pushed
the
swap-macOS-for-Darwin
branch
from
a604f5a
to
bf2a155
Compare
|
Ready for real Review |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #181
Summary
While working on #78, I quickly found that the issue is not so much speed but platform enablement for Darwin, a theme I am finding in the repo. This change will help us in bringing alignment between the scripts that are meant to work on both Linux and Darwin, by simpifying / hardneing our process around pieces that are platform dependent
Release Note
Change naming conventions from
macOStoDarwinDocumentation
No changes in the sigstore dev docs, but the repo
README.mdhas been updated