-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripts for benchmarks using the current API #306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Maruseac <[email protected]>
Signed-off-by: Mihai Maruseac <[email protected]>
Signed-off-by: Mihai Maruseac <[email protected]>
Signed-off-by: Mihai Maruseac <[email protected]>
Signed-off-by: Mihai Maruseac <[email protected]>
Signed-off-by: Mihai Maruseac <[email protected]>
Signed-off-by: Mihai Maruseac <[email protected]>
We go from ``` [...]$ hyperfine -w 3 "python benchmarks/generate.py file --root /tmp/file 100000000" Benchmark 1: python benchmarks/generate.py file --root /tmp/file 100000000 Time (mean ± σ): 10.290 s ± 0.140 s [User: 10.197 s, System: 0.092 s] Range (min … max): 10.149 s … 10.541 s 10 runs ``` to ``` [...]$ hyperfine -w 3 "python benchmarks/generate.py file --root /tmp/file 100000000" --show-output Benchmark 1: python benchmarks/generate.py file --root /tmp/file 100000000 Time (mean ± σ): 381.1 ms ± 13.9 ms [User: 512.9 ms, System: 633.1 ms] Range (min … max): 365.5 ms … 412.1 ms 10 runs ``` Signed-off-by: Mihai Maruseac <[email protected]>
Signed-off-by: Mihai Maruseac <[email protected]>
Signed-off-by: Mihai Maruseac <[email protected]>
jiggoha
reviewed
Sep 11, 2024
Signed-off-by: Mihai Maruseac <[email protected]>
Signed-off-by: Mihai Maruseac <[email protected]>
Signed-off-by: Mihai Maruseac <[email protected]>
Signed-off-by: Mihai Maruseac <[email protected]>
spencerschrock
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These are the scripts to generate sample models for benchmarks and to benchmark serializing models from disk to the in-toto statements (or the digest) used just before signing.
I will follow up with another PR where we have some benchmark data, currently running these. I'll also add those numbers to a README which explains how to run these and what experiments were considering.
Wanted to have it here before I move on cleaning the API a little. If you look at the benchmark harness, we have quite a large number of options and the APIs should be very similar. So I'll work on that next, while benchmarks here are running.
We should be able to use this and compare against the numbers in #13 (and also investigate SHA256 vs BLAKE2).
Fixes #206 in that the benchmarks are public, but we should still get benchmarks data before releasing stable version of library.
Release Note
NONE
Documentation
NONE