Simplify test data getters #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codysoyland
force-pushed
the
refactor-testdata
branch
from
1b35b5a to
1aacf8e
Compare
Signed-off-by: Cody Soyland <[email protected]>
codysoyland
force-pushed
the
refactor-testdata
branch
from
1aacf8e to
72b6461
Compare
Signed-off-by: Cody Soyland <[email protected]>
kommendorkapten
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I find the existing test data functions a bit confusing and require a lot of boilerplate, so I decided it would be cleaner to modify the helpers to be more general and fetch by filename.
I also renamed the bundles to be more consistent and use the
.sigstore.jsonextension.Release Note
Documentation