Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor verifier to perform steps in the order given by the spec #55

Conversation

@segiddins segiddins force-pushed the segiddins/refactor-verifier-to-perform-steps-in-the-order-given-by-the-spec branch from e15d3ff to 6402076 Compare June 28, 2024 18:33
@segiddins segiddins marked this pull request as ready for review June 28, 2024 19:49
@segiddins segiddins force-pushed the segiddins/refactor-verifier-to-perform-steps-in-the-order-given-by-the-spec branch from 6402076 to 51a7c4b Compare July 1, 2024 22:22
@segiddins segiddins requested a review from woodruffw July 1, 2024 22:42
lib/sigstore/verifier.rb Outdated Show resolved Hide resolved
Signed-off-by: Samuel Giddins <[email protected]>
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for my belated re-review here.

@woodruffw woodruffw enabled auto-merge (squash) July 22, 2024 20:48
@woodruffw woodruffw merged commit 53db690 into main Jul 22, 2024
15 checks passed
@woodruffw woodruffw deleted the segiddins/refactor-verifier-to-perform-steps-in-the-order-given-by-the-spec branch July 22, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants