Skip to content

Commit

Permalink
chore: migrate from eslint-plugin-node to eslint-plugin-n
Browse files Browse the repository at this point in the history
  • Loading branch information
SimenB committed Jun 22, 2024
1 parent a253c89 commit c9907fa
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"plugins": ["prettier"],
"extends": [
"eslint:recommended",
"plugin:node/recommended",
"plugin:n/recommended",
"plugin:prettier/recommended"
],
"env": {
Expand Down Expand Up @@ -78,7 +78,7 @@
"rules": {
"no-shadow": "off",
"@typescript-eslint/no-shadow": "warn",
"node/no-unsupported-features/es-syntax": "off"
"n/no-unsupported-features/es-syntax": "off"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ benchmarks.suite('gauge', require('./gauge'));
benchmarks.suite('summary', require('./summary'));
benchmarks.run().catch(err => {
console.error(err.stack);
// eslint-disable-next-line no-process-exit
// eslint-disable-next-line n/no-process-exit
process.exit(1);
});
1 change: 0 additions & 1 deletion lib/metrics/eventLoopLag.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ const Gauge = require('../gauge');
// Check if perf_hooks module is available
let perf_hooks;
try {
/* eslint-disable node/no-unsupported-features/node-builtins */
perf_hooks = require('perf_hooks');
} catch {
// node version is too old
Expand Down
6 changes: 3 additions & 3 deletions lib/pushgateway.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class Pushgateway {
}
async function useGateway(method, job, groupings) {
// `URL` first added in v6.13.0
// eslint-disable-next-line node/no-deprecated-api
// eslint-disable-next-line n/no-deprecated-api
const gatewayUrlParsed = url.parse(this.gatewayUrl);
const gatewayUrlPath =
gatewayUrlParsed.pathname && gatewayUrlParsed.pathname !== '/'
Expand All @@ -58,9 +58,9 @@ async function useGateway(method, job, groupings) {
: '';
const path = `${gatewayUrlPath}/metrics${jobPath}`;

// eslint-disable-next-line node/no-deprecated-api
// eslint-disable-next-line n/no-deprecated-api
const target = url.resolve(this.gatewayUrl, path);
// eslint-disable-next-line node/no-deprecated-api
// eslint-disable-next-line n/no-deprecated-api
const requestParams = url.parse(target);
const httpModule = isHttps(requestParams.href) ? https : http;
const options = Object.assign(requestParams, this.requestOptions, {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"@typescript-eslint/parser": "^6.21.0",
"eslint": "^8.32.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-node": "^11.0.0",
"eslint-plugin-n": "^16.0.0",
"eslint-plugin-prettier": "^5.0.1",
"express": "^4.13.3",
"husky": "^9.0.0",
Expand Down

0 comments on commit c9907fa

Please sign in to comment.