Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable bun.js by catching NotImplemented error #624

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

owlcode
Copy link
Contributor

@owlcode owlcode commented Apr 2, 2024

Catch error thrown by bun.js when calling perf_hooks.monitorEventLoopDelay

Following up on #599 - bun.js already introduced some of the missing APIs (or created stubs) so to the best of my knowledge this is the last thing which is required to make default gc stats work for bun (at least it worked for me with this change).

Error is also reported in bun's repository - oven-sh/bun#4708 (comment)

Fixes #570
Closes #623

lib/metrics/eventLoopLag.js Outdated Show resolved Hide resolved
lib/metrics/heapSpacesSizeAndUsed.js Outdated Show resolved Hide resolved
@owlcode owlcode requested a review from SimenB April 3, 2024 08:45
@SimenB
Copy link
Collaborator

SimenB commented Apr 3, 2024

Can you include the CI stuff from #599?

@owlcode
Copy link
Contributor Author

owlcode commented Apr 3, 2024

Can you include the CI stuff from #599?

Done

Copy link
Collaborator

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 99b25a4 into siimon:master Apr 8, 2024
14 checks passed
@SimenB
Copy link
Collaborator

SimenB commented Apr 16, 2024

https://github.com/siimon/prom-client/releases/tag/v15.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide exclusions for default metrics collected Is it possible to use in Bun/Deno/other runtime?
2 participants