Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials API, create, exist config, destroy and list #122

Merged
merged 12 commits into from
Feb 10, 2024

Conversation

WhiteWalkerMT
Copy link
Contributor

Added Credentials API that supports:

  • create
  • exist
  • config
  • destroy
  • list

All operations can be done on a folder as a system credential.
Added Credential plugin.
Cleaning all system credentials after a test.
VScode debug and run configuration for nock and without nock for easy debugging

Copy link
Owner

@silas silas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good, thanks for the PR!

Want to address the comments I added and run prettier to fix CI, then I'll do some local testing and we can get this merged/released.

README.md Outdated Show resolved Hide resolved
lib/credentials.js Show resolved Hide resolved
lib/jenkins.js Show resolved Hide resolved
lib/jenkins.js Outdated Show resolved Hide resolved
lib/jenkins.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
@silas silas merged commit d0d3ab9 into silas:main Feb 10, 2024
3 checks passed
@silas
Copy link
Owner

silas commented Feb 10, 2024

Thanks for the PR, I'll get this released shortly!

@WhiteWalkerMT WhiteWalkerMT deleted the credentials-api branch February 11, 2024 00:14
@silas
Copy link
Owner

silas commented Feb 11, 2024

Released in [email protected], thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants