Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log when a trusted bot is recognized #87

Merged
merged 2 commits into from
Dec 10, 2024
Merged

log when a trusted bot is recognized #87

merged 2 commits into from
Dec 10, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Dec 10, 2024

ETH-1042 Redirect Error

@briskt briskt requested a review from a team as a code owner December 10, 2024 02:16
@briskt briskt requested review from jason-jackson and hobbitronics and removed request for a team December 10, 2024 02:16
Copy link

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity what is the specific reason for using p.log.Debug vs p.log.Info?

@briskt
Copy link
Contributor Author

briskt commented Dec 10, 2024

Out of curiosity what is the specific reason for using p.log.Debug vs p.log.Info?

Well, in this case, it's just to avoid noise in the logs. I'd like to come up with a set of rules to help decide what level to use, though I'm not sure that would be all that effective either.

@briskt briskt merged commit 8d82421 into main Dec 10, 2024
5 checks passed
@briskt briskt deleted the log-bot branch December 10, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants