Merge pull request #1332 from sillsdev/ensure-dispose-of-stream-in-mi…

…gration Added using to ensure that the XSL stream gets disposed in DoOneMigrationStep
sillsdev · Aug 1, 2024 · e8ce8b2 · e8ce8b2
2 parents 4cceb9a + 6e99a66
commit e8ce8b2
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/SIL.Lift/Migration/Migrator.cs b/SIL.Lift/Migration/Migrator.cs
@@ -56,12 +56,15 @@ public static string MigrateToLatestVersion(string pathToOriginalLift)
 
 		private static void DoOneMigrationStep(string xslName, string migrationSourcePath, string migrationTargetPath)
 		{
-			Stream xslstream = Assembly.GetExecutingAssembly().GetManifestResourceStream(xslName);
-			if (xslstream != null)
+			using (var xslstream =
+			       Assembly.GetExecutingAssembly().GetManifestResourceStream(xslName))
 			{
-				XslCompiledTransform xsl = new XslCompiledTransform();
-				xsl.Load(new XmlTextReader(xslstream));
-				xsl.Transform(migrationSourcePath, migrationTargetPath);
+				if (xslstream != null)
+				{
+					XslCompiledTransform xsl = new XslCompiledTransform();
+					xsl.Load(new XmlTextReader(xslstream));
+					xsl.Transform(migrationSourcePath, migrationTargetPath);
+				}
 			}
 		}