Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made FluentAssertXml classes use "Assert.That" so they can work in clients that use NUnit 4. #1373

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Made FluentAssertXml classes use "Assert.That" so they can work in clients that use NUnit 4. #1373

merged 1 commit into from
Jan 13, 2025

Conversation

tombogle
Copy link
Contributor

@tombogle tombogle commented Jan 10, 2025 •
edited by andrew-polk
Loading

Also fixed a typo in DblMetadata

This change is Reviewable

@tombogle
Made FluentAssertXml classes use "Assert.That" so they can work in cl…
a1dd00d 
…ients that use NUnit 4.

Also fixed a typo in DblMetadata
@tombogle tombogle requested a review from andrew-polk January 10, 2025 23:07
@tombogle tombogle self-assigned this Jan 10, 2025
@github-actions GitHub Actions
Copy link

Palaso Tests

     3 files  ±    0       3 suites  ±0   19m 50s ⏱️ + 4m 22s
 4 885 tests ±    0   4 652 ✅ ±    0  233 💤 ± 0  0 ❌ ±0 
14 118 runs  +1 562  13 487 ✅ +1 508  631 💤 +54  0 ❌ ±0 

Results for commit a1dd00d. ± Comparison against base commit 6bbcd35.

@tombogle tombogle requested a review from ermshiperete January 11, 2025 00:51
@tombogle tombogle merged commit 17bf041 into master Jan 13, 2025
6 checks passed
@tombogle tombogle deleted the improve-fluentassertxml branch January 13, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermshiperete ermshiperete ermshiperete approved these changes

@andrew-polk andrew-polk Awaiting requested review from andrew-polk

Assignees

@tombogle tombogle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombogle @ermshiperete