Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use named HTTP clients for ClearML #115

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Oct 18, 2023


This change is Reviewable

- move ClearML connection string to "ConnectionStrings" section
- fixes #108
@johnml1135
Copy link
Collaborator

src/SIL.Machine.AspNetCore/Configuration/ClearMLOptions.cs line 7 at r1 (raw file):

    public const string Key = "ClearML";

    public string Queue { get; set; } = "default";

Where is the Url for ClearML stored now? Will the k8s deployments, etc. need to be changed?

@codecov-commenter
Copy link

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...Machine.AspNetCore/Configuration/ClearMLOptions.cs 100.00% <ø> (ø)
.../SIL.Machine.AspNetCore/Services/ClearMLService.cs 35.48% <100.00%> (ø)
...spNetCore/Services/ClearMLAuthenticationService.cs 0.00% <0.00%> (ø)
....Machine.AspNetCore/Services/ClearMLHealthCheck.cs 0.00% <0.00%> (ø)
...NetCore/Configuration/IMachineBuilderExtensions.cs 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)

@johnml1135
Copy link
Collaborator

src/SIL.Machine.AspNetCore/Configuration/ClearMLOptions.cs line 7 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Where is the Url for ClearML stored now? Will the k8s deployments, etc. need to be changed?

I see it.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 7c9440f into master Oct 18, 2023
@ddaspit ddaspit deleted the clearml-http-client branch October 18, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClearML Refreshes Token too frequently
3 participants