-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #133 #135
Fixes #133 #135
Conversation
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @johnml1135)
src/SIL.Machine.AspNetCore/Services/ClearMLHealthCheck.cs
line 35 at r1 (raw file):
$"No ClearML agents are available for configured queue \"{_options.CurrentValue.Queue}\"" ); _numConsecutiveFailures = 0;
You should be locking all access to _numConsecutiveFailures
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @johnml1135)
src/SIL.Machine.AspNetCore/Services/ClearMLHealthCheck.cs
line 35 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
You should be locking all access to
_numConsecutiveFailures
.
Done. I noticed that S3 was missing a lock as well in the same place, so I changed that as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
Implemented same logic in ClearML as in S3.
This change is