Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #133 #135

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Fixes #133 #135

merged 2 commits into from
Nov 10, 2023

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Nov 10, 2023

Implemented same logic in ClearML as in S3.


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...NetCore/Configuration/IMachineBuilderExtensions.cs 0.00% <0.00%> (ø)
....Machine.AspNetCore/Services/ClearMLHealthCheck.cs 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @johnml1135)


src/SIL.Machine.AspNetCore/Services/ClearMLHealthCheck.cs line 35 at r1 (raw file):

                    $"No ClearML agents are available for configured queue \"{_options.CurrentValue.Queue}\""
                );
            _numConsecutiveFailures = 0;

You should be locking all access to _numConsecutiveFailures.

Copy link
Collaborator Author

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @johnml1135)


src/SIL.Machine.AspNetCore/Services/ClearMLHealthCheck.cs line 35 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

You should be locking all access to _numConsecutiveFailures.

Done. I noticed that S3 was missing a lock as well in the same place, so I changed that as well.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@johnml1135 johnml1135 merged commit 7a225d6 into master Nov 10, 2023
3 checks passed
@Enkidu93 Enkidu93 deleted the clearml_healthcheck_singleton branch November 20, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants