Refactor models to records

[ddaspit]

This change is 

[johnml1135]

Why are the options not also converted?

[johnml1135]

src/SIL.Machine.AspNetCore/Services/NmtPreprocessBuildJob.cs line 87 at r1 (raw file):

        Dictionary<string, int> counts = new();
        counts["CorpusSize"] = 0;

Why is corpus size removed?

[johnml1135]

src/SIL.Machine.AspNetCore/Services/NmtPreprocessBuildJob.cs line 117 at r1 (raw file):

                        corpus.TrainOnTextIds.Add(keyTermsTextIds.First()); //Should only be one textId for key terms
                    parallelCorpora.Add(parallelKeyTermsCorpus);
                }

Why was this removed?

[johnml1135]

src/SIL.Machine.AspNetCore/Services/NmtPreprocessBuildJob.cs line 117 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Why was this removed?

Why was it moved below?

[johnml1135]

src/SIL.Machine.AspNetCore/Services/NmtPreprocessBuildJob.cs line 171 at r1 (raw file):

                        await sourceTrainWriter.WriteAsync($"{row.SourceText}\n");
                        await targetTrainWriter.WriteAsync($"{row.TargetText}\n");
                        trainCount++;

Is this tested?

[johnml1135]

Reviewed 30 of 30 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ddaspit)

[ddaspit]

I was focusing on the models. We could convert the option classes to records in a future PR.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @johnml1135)

---

src/SIL.Machine.AspNetCore/Services/NmtPreprocessBuildJob.cs line 87 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Why is corpus size removed?

I believe that the corpus size and the train count were trying to capture the same thing.

---

src/SIL.Machine.AspNetCore/Services/NmtPreprocessBuildJob.cs line 117 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Why was it moved below?

The models were updated to be immutable. The old logic worked by updating a property of the model, which isn't a great idea anyway. To avoid updating the model, I moved the code below. I think the logic is clearer this way as well.

---

src/SIL.Machine.AspNetCore/Services/NmtPreprocessBuildJob.cs line 171 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Is this tested?

It looks like there are some unit tests for key terms.

[johnml1135]

Tracked here: #174

[johnml1135]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)