If specified as empty, train on nothing

sillsdev · Nov 8, 2023 · baeba70 · baeba70
1 parent 7c917b9
commit baeba70
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Serval.Translation/Controllers/TranslationEnginesController.cs b/src/Serval.Translation/Controllers/TranslationEnginesController.cs
@@ -772,7 +772,7 @@ CancellationToken cancellationToken
     /// you may flag a subset of books for pretranslation by including their [abbreviations](https://github.com/sillsdev/libpalaso/blob/master/SIL.Scripture/Canon.cs)
     /// in the textIds parameter. If the engine does not support pretranslation, these fields have no effect.
     ///
-    /// Similarly, specify the corpora and textIds to train on. If none are provided, all corpora will be used.
+    /// Similarly, specify the corpora and textIds to train on. If no train_on field is provided, all corpora will be used.
     ///
     /// The `"options"` parameter of the build config provides the ability to pass build configuration parameters as a JSON object.
     /// A typical use case would be to set `"options"` to `{"max_steps":10}` in order to configure the maximum

diff --git a/src/Serval.Translation/Services/EngineService.cs b/src/Serval.Translation/Services/EngineService.cs
@@ -217,7 +217,7 @@ public async Task<bool> StartBuildAsync(Build build, CancellationToken cancellat
                             if (trainingCorpus.TextIds is not null)
                                 corpus.TrainOnTextIds.Add(trainingCorpus.TextIds);
                         }
-                        else if (trainOn is null || trainOn.Count == 0)
+                        else if (trainOn is not null && trainOn.Count == 0)
                         {
                             corpus.TrainOnAll = true;
                         }