Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
set a fake version when trying to build installer, don't sign or rele…
Browse files Browse the repository at this point in the history
…ase from PRs
hahn-kev authored Nov 27, 2024
1 parent 896919b commit d7f6945
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/installer-release.yml
Original file line number Diff line number Diff line change
@@ -20,13 +20,19 @@ jobs:
fetch-depth: '0'

- name: Set VERSION (e.g. 1.0.0) and FULL_VERSION (e.g. 1.0.0-abcdef4)
if: github.event_name != 'pull_request'
run: |
VERSION="${GITHUB_REF#refs/tags/v}"
SHORT_SHA=$(git rev-parse --short HEAD)
FULL_VERSION="${VERSION}-${SHORT_SHA}"
echo "VERSION=${VERSION}" >> $GITHUB_ENV
echo "FULL_VERSION=${FULL_VERSION}" >> $GITHUB_ENV
shell: bash
- name: set fake version for PR
if: github.event_name == 'pull_request'
run: |
echo "VERSION=0.0.1" >> $GITHUB_ENV
echo "FULL_VERSION=0.0.1-pr" >> $GITHUB_ENV
- name: Validate version format
run: |
@@ -77,14 +83,14 @@ jobs:

- name: Sign Installer
uses: sillsdev/codesign/trusted-signing-action@v3
if: startsWith(github.ref, 'refs/tags/v')
if: startsWith(github.ref, 'refs/tags/v') && github.event_name != 'pull_request'
with:
credentials: ${{ secrets.TRUSTED_SIGNING_CREDENTIALS }}
files-folder: installer/Output
files-folder-filter: SolidInstaller*.exe

- name: Create Release
if: startsWith(github.ref, 'refs/tags/v')
if: startsWith(github.ref, 'refs/tags/v') && github.event_name != 'pull_request'
uses: softprops/action-gh-release@v2
with:
files: installer/Output/SolidInstaller*.exe

0 comments on commit d7f6945

Please sign in to comment.