Switch to inline type imports #1732
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Jan 15, 2025
| @@ -16,6 +16,7 @@ | |||
| "typescript.tsdk": "node_modules/typescript/lib", | |||
| "typescript.enablePromptUseWorkspaceTsdk": true, | |||
| "typescript.preferences.importModuleSpecifier": "relative", | |||
| "typescript.preferences.preferTypeOnlyAutoImports": true, | |||
There was a problem hiding this comment.
Oversight: I had this in my user settings instead of in the project's settings.
eslint.config.base.js
Outdated
There was a problem hiding this comment.
Just a comment to surface the ESLint config changes that make all this happen.
axelboc
force-pushed
the
inline-type-imports
branch
from
faa9420 to
746f43f
Compare
axelboc
force-pushed
the
inline-type-imports
branch
2 times, most recently
from
e802e29 to
faebae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to avoid duplicate imports (one for types and one for values). Having the
typekeyword right before each import is also clearer in my opinion.Of course, you win some, you lose some: when importing a lot of types from the same module, we get a lot of
typekeywords, which can also lead to Prettier wrapping imports onto separate lines, which is why slightly more lines are added than removed in the diff.