Fix min() so it can be positive #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hazurl
previously approved these changes
Feb 16, 2021
|
@Hazurl, sorry I should have marked this as not ready yet. I had not seen your comment and force pushed. Now your comments are gone. |
|
So, there is a CI error that I cannot reproduce locally. |
|
@simonask is there anything I can do to get this closer to being merged? |
|
@simonask sorry for the ping but is there anything I can do to get this closer to being merged? |
I don't fully understand what was the problem in the other case but moving out the && parameter seems to be the better move here anyway.
|
@simonask I fixed the CI here as well. Would you mind merging this one? |
|
@simonask sorry for the ping but is there anything I can do to get this closer to being merged? |
|
@simonask maybe this can be merged in 2024? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.