Fix json formatter to write result to file continuously #21
Conversation
| @@ -12,7 +12,7 @@ before_install: | |||
|
|
|||
| install: | |||
| - npm install | |||
| - npm install cucumber | |||
| - npm install cucumber@1.0.0 | |||
There was a problem hiding this comment.
@peter-reperger I notice the latest version of cucumber is 1.2.2 https://www.npmjs.com/package/cucumber - does the code work with 1.1.x or 1.2.x or just version 1.0.0?
The version number is quite specific in the npm install. I.e. it's not ~1.0.0 or ^1.0.0 (https://docs.npmjs.com/getting-started/semantic-versioning). Looking at package.json I guess this could be at least ~1.0.0.
There was a problem hiding this comment.
@simondean The code works only with cucumber 1.0.0, because in 1.1.0 they introduced a breaking change (AstTreeWalker was completely rewritten).
I'll update the npm install version to use '~1.0.0'
|
@peter-reperger thanks for the pull request. I've added some comments to the code. |
peter-reperger
force-pushed
the
json-output-formatter-fix
branch
from
bcde91b to
c47d0ce
Compare
|
@simondean I've updated the PR and resolved the conflicts. |
With the latest update, writing json results to file was done at the very end of execution. This has been changed back to the original behaviour: now json result is written to file continuously.
Also, cucumber dependency had to be changed: compatible version is 1.0.0, because breaking changes were introduced in cucumber version 1.1.0 (AstTreeWalker has been rewritten).