[#13144] copy enroll student #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonliuanu
requested review from
JeongJoonLee-kr
and removed request for
JeongJoonLee-kr
|
The code has implemented basic functions and has appropriate prompts for different situations. Unnecessary comments have been deleted to make the code concise. |
|
This code logic is solid. I can't find any problem with code and I've tested under various number of students and there was no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outline of Solution
Added a 'Copy' button in course enroll page to let instructors to import existing students into new students sheet below to support the feature proposed in #13144.
Before implementation:
After implementation the new page looks like this with the 'Copy' button:
After clicking 'Copy', students are copied with information shows up: