Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ibootbar agent acq crashing during reconnection #496

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

davidvng
Copy link
Contributor

@davidvng davidvng commented Aug 7, 2023

Description

Fixes agent acq process crashing on reconnection. Continues loop on SNMP disconnect.

Motivation and Context

Resolves #492

How Has This Been Tested?

Tested in lab on ibootbar.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@davidvng davidvng added the bug Something isn't working label Aug 7, 2023
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just one comment on the raise ConnectionError().

socs/agents/ibootbar/agent.py Outdated Show resolved Hide resolved
@BrianJKoopman BrianJKoopman merged commit 986042c into main Aug 9, 2023
2 checks passed
@BrianJKoopman BrianJKoopman deleted the ibootbar_connection branch August 9, 2023 19:29
hnakata-JP pushed a commit that referenced this pull request Apr 12, 2024
* continue when connection drops

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* removed raise connectionerror

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iBootbar Agent acq process crashes during reconnection
2 participants