Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LS372 Agent: Add ability in config file to set channel resistance range #500

Merged
merged 8 commits into from
Aug 9, 2023

Conversation

sanahabhimani
Copy link
Contributor

Description

Allows the user to choose between autorange or a set resistance range for a 372 channel.

Motivation and Context

Resolves #495

How Has This Been Tested?

Tested in the lab on a 372 at Yale

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sanahabhimani sanahabhimani added enhancement New feature or request agent: ls372 labels Aug 8, 2023
@sanahabhimani sanahabhimani self-assigned this Aug 8, 2023
@BrianJKoopman BrianJKoopman merged commit ffbf385 into main Aug 9, 2023
4 checks passed
@BrianJKoopman BrianJKoopman deleted the ls372-configfile-res branch August 9, 2023 14:18
hnakata-JP pushed a commit that referenced this pull request Apr 12, 2024
…ge (#500)

* add resistance range ability to config file task

* change resistance range of channel iff autorange off

* move log statement up to elif condition

* add the closest valid range set in the log statement

* add resistance_range to config file example

* fix for not adding resistance range line for all channels in config file ex

* fix calibration_curve_num type in docs

* add note about float and fix example accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent: ls372 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

372--config file, add resistance range
2 participants