Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets PID freq to 0 when PMX is turned off #502

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

jlashner
Copy link
Collaborator

Small change to the supervisor that sets the PID freq to zero when you call PmxOff

Description

Small change just to ensure you don't leave the PID set to a weird state, and to make it more clear in grafana that things are off.

Motivation and Context

Mainly to make grafana panels look more consistent

How Has This Been Tested?

Tested on satp1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman merged commit d99fce4 into main Aug 11, 2023
2 checks passed
@BrianJKoopman BrianJKoopman deleted the zero-target-freq-pmx-off branch August 11, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants