Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCSClient crossbar address override to wg kikusui agent #511

Closed
wants to merge 2 commits into from

Conversation

BrianJKoopman
Copy link
Member

Description

This adds the ability for the Wiregrid Kikusui agent to pull the SITE_HTTP environment variable and use it for the OCSClient connection to the wiregrid encoder agent. It also adds an argument to the agent that allows overriding the env var.

Motivation and Context

At site the docker host running the wiregrid kikusui agent has a host wide configuration in the SCF for the docker network based address for the crossbar server, while the container runs in network mode host and uses the SITE_HTTP env var to override the host wide config, allowing the kikusui agent to start.

However, it then crashes when trying to connect a client to interact with the encoder agent because that client connection tries to use the host wide configuration pointing to a name that can't be resolved.

As I write this I realize this could probably also be fixed by putting the internal docker domain name for the crossbar server in the hosts file...I'm going to try that too before merging this.

How Has This Been Tested?

This was tested at site.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Depending on the site configuration file it's likely that the agent is given a
crossbar address it can resolve via environment variable, but the address for
the host in the SCF won't resolve in the container. This causes the OCS Client
to not connect for the encoder agent interaction.
@BrianJKoopman
Copy link
Member Author

This is no longer really needed. I solved this problem by adding the internal crossbar network's domain name for the crossbar server to the host systems /etc/hosts file. This hosts file is used within all containers and allows resolution of the crossbar address for the OCSClient to connect to even when the container is in network_mode: host.

@BrianJKoopman BrianJKoopman deleted the koopman/ocs-client-update-wg-kikusui branch August 23, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant