Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap LSL/LSR/ST1 <--> LSL/LSR/ST2 for the bug fix at the site #512

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

sadachi5
Copy link
Contributor

Description

Swapping limit switch/stopper 1 and limit switch/stopper 2 to fix the bug at the site. This change can be acceptable for all the SATs.

Motivation and Context

This change is needed to correctly operate the wire grid at the site.

How Has This Been Tested?

Actually, it should be tested at the site. To do so, however, approval of the pulling request and updating the docker-hub are necessary. This is an argent task.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sadachi5 sadachi5 added the bug Something isn't working label Aug 22, 2023
@BrianJKoopman BrianJKoopman merged commit 7dd21f5 into main Aug 22, 2023
2 checks passed
@BrianJKoopman BrianJKoopman deleted the modify_for_site_wiregrid_actuator branch August 22, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants