Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding agent for the Lightning Detector #640

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

felipecarrero
Copy link

@felipecarrero felipecarrero commented Mar 12, 2024

Created an agent for the lightning detector that recieves data through the local network via UDP.

Description

The agent opens a socket and binds a port (1110) then receives packages sent by the lightning detector, parses them into a dictionary and publishes them to the agent feed.

Motivation and Context

No agent for the lightning detector exists.

How Has This Been Tested?

Testing carried out in daq-dev and monitoring through Grafana.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @felipecarrero! A few comments, questions, and requests below. Happy to discuss any of these in person too.

socs/agents/ld_monitor/agent.py Show resolved Hide resolved
socs/agents/ld_monitor/agent.py Outdated Show resolved Hide resolved
socs/agents/ld_monitor/agent.py Outdated Show resolved Hide resolved
socs/agents/ld_monitor/agent.py Outdated Show resolved Hide resolved
socs/agents/ld_monitor/agent.py Outdated Show resolved Hide resolved
socs/agents/ld_monitor/agent.py Outdated Show resolved Hide resolved
socs/agents/ld_monitor/agent.py Outdated Show resolved Hide resolved
socs/agents/ld_monitor/agent.py Outdated Show resolved Hide resolved
socs/agents/ld_monitor/agent.py Outdated Show resolved Hide resolved
socs/agents/ld_monitor/agent.py Outdated Show resolved Hide resolved
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking in on this. One small comment the changes, but then also still need the docs page for this agent. Anything I can do to help with that?

socs/agents/ld_monitor/agent.py Outdated Show resolved Hide resolved
@BrianJKoopman BrianJKoopman self-requested a review May 7, 2024 04:26
@BrianJKoopman BrianJKoopman added the new agent New OCS agent needs to be created label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new agent New OCS agent needs to be created
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants