Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch build-backend from setuptools to hatchling #758

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

BrianJKoopman
Copy link
Member

Description

This PR switches the build system backend from setuptools to hatchling. It follows the same steps taken in ocs.

The same versioning side-effect applies. Versions on installs from source will be slightly different now:

old version format: 0.5.0+14.gc4b73f75
new version format: 0.5.0.post1.dev14+gc4b73f75

I also added and organized some of the dependencies across the pyproject.toml and requirements.txt files.

Motivation and Context

See simonsobs/ocs#403.

How Has This Been Tested?

I have built the package and inspected the resulting sdist. I also ran tests against an installation from the built wheel. This required manual installation of the dependencies not available on PyPI, but after that tests ran mostly fine. I did experience a hanging test related to an SNMP agent, but I was unable to reproduce. We'll see how the tests in the CI go.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Packaging change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman merged commit 81e5916 into main Sep 26, 2024
7 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/hatch-backend branch September 26, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant