Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiregrid Actuator Agent: Add 'position' data in session.data #794

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

d-hoshino2626
Copy link
Contributor

Description

I added 'position' data, which means the wiregrid is in the view of the telescope ('inside') or out of the view ('outside'), in session.data.

Motivation and Context

This change enables to monitor the location of the wiregrid easily.

How Has This Been Tested?

no test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for moving this over from runlib. Any plans to test before we squash and merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants