Check there is enough time before starting seq.scan()
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianJKoopman
added a commit
to simonsobs/scheduler
that referenced
this pull request
Oct 17, 2024
BrianJKoopman
added a commit
to simonsobs/scheduler
that referenced
this pull request
Oct 17, 2024
This ensures that scans are at least `min_duration` long, otherwise it skips the scan entirely.
BrianJKoopman
force-pushed
the
koopman/min-scan-duration
branch
from
edd8f37
to
1f0babb
Compare
kmharrington
pushed a commit
to simonsobs/scheduler
that referenced
this pull request
Oct 26, 2024
BrianJKoopman
added a commit
to simonsobs/scheduler
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the "minimum duration" argument discussed in #169. This argument specifies the minimum number of seconds before the
stop_timethat we need to be able to start scanning.Along with this we also add a quick check on the current time compared to the
stop_time. Ifstop_timehas already passed, we skip the scan entirely.Resolves #169.