-
Notifications
You must be signed in to change notification settings - Fork 0
setup a stable and latest build in travis ci #19
Conversation
Conflicts: .travis.yml
@khiltunen, This PR is ready for review. We setups two builds on travis-ci for every change that is pushed to github. The first build is against a stable version of simphony-common (currently 0.1.2) and the second build is for then latest master commit of simphony-common. The seconds build is designated as a build that can fail This setup will help when you are adding features in the openfoam-simphony wrapper. By selecting a specific simphony version for testing to avoid the false positives that are due to recent changes in simphony common. Thus the PR can be reviewed tested and merged without problems. At the same time by having the cutting edge built at the same time you can check to see what breaks with the new version of simphony and thus make a separate PR making the necessary changes. As a result you separate the concepts of writing code to add a feature ro fix a bug in simphony-opefoam and writing code to support a new version of simhony. |
@khiltunen is this ok to merge? |
Yes. |
ok, I will update the branch to let travis-ci run one more time and then merge. Thanks |
@khiltunen, I think that his PR might conflict with #23, so I think that it is better if we revisit this after #23 is merged |
Your are right. Let's wait for the #23. |
Closing as it's no longer relevant. |
This PR fixes #17. We setup two builds in travis-ci one working on the latest stable release of simphony-common that openfoam master supports and the other on the latest master version of simphony-common. The cutting edge build failure or success will not affect the commit status on PRs but will provide a preview on what currently breaks and will need to be fixed in order to use the latest simphony-common code.