Use common 0.2 #53
Use common 0.2 #53
Conversation
|
@nathanfranklin do you have time to review the changes on this PR ? |
|
@khiltunen , i won't have time till Tueasday. If that is okay, I will take a look then. |
|
That's okay. Thank's ! |
| @@ -181,8 +184,7 @@ def __init__(self, name, BC=None, mesh=None, path=None): | |||
| foamface.writeMesh(name) | |||
|
|
|||
| # write possible cell data to time directory | |||
| for cell in mesh.iter_cells(): | |||
| self.update_cell(cell) | |||
| self.update_cells(list(mesh.iter_cells())) | |||
There was a problem hiding this comment.
list could be removed:
self.update_cells(mesh.iter_cells())
Note though that you are using mesh here without testing if it is possibly None
There was a problem hiding this comment.
list removed and corresponding change made on update_cells method.
update_cells() call is inside
if mesh:
|
The
|
|
In addition to some examples, I don't know if the best solution is to add tables (hdf5) as a requirement or to remove its use in that test as on first look it seems like the test itself is only actually uses the openfoam-file format. If you do add it as a requirement, see the following from simphony's README:
|
| @@ -3,7 +3,7 @@ | |||
| """ | |||
|
|
|||
| from foam_controlwrapper.foam_controlwrapper import FoamControlWrapper | |||
| from foam_controlwrapper.foam_controlwrapper import read_foammesh | |||
| from foam_controlwrapper.mesh_utils import read_foammesh | |||
There was a problem hiding this comment.
read_foammesh is no longer in mesh_utils
|
The examples |
|
I can't get those fail. Could you provide the error thread ? |
My mistake. I forgot to reinstall. Sorry. |
|
Not at all. Thank's again for valuable comment's ! |
glad to help. Just left one more comment. Otherwise, looks good to me 👍 |
This PR makes openfoam wrappers compatible with the common 0.2.0 version (issue #51). Also issue #25 concerning unittest fails when running from specific folders is fixed. Now the needed cuds data is constructed when tests are executed.