Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev´s #261

Open
wants to merge 31 commits into
base: dev
Choose a base branch
from
Open

dev´s #261

wants to merge 31 commits into from

Conversation

Juanduino
Copy link

No description provided.

@Juanduino
Copy link
Author

Feel free to integrate it, if you have some ideas?

@Juanduino
Copy link
Author

This is compiling on my end

@runger1101001
Copy link
Member

Oooof....

In terms of the CORDIC stuff, this won't work like this. I don't want to merge anything related to CORDIC into the main library. It's not useful to 99.8% of our users, and it will make all the test-builds fail if left in like this.
To get the CORDIC functionality, I have recently merged to the dev branch changes which enable you to supply your own versions of the _sin() and _cos() functions.

In terms of the 8-PWM stuff, I can't follow all these changes :-)
It should be possible to do it, but the model is not clear to me:

  • do you expect 8 PWM channels on the same timer? I don't think the MCUs can do it?
  • do you expect to use complimentary channels (CHx and CHxN)?
  • or does none of this matter, and you just want 4 pairs of pins, with each pair on the same timer?
  • I see you expect dead-time insertion? I think its needed for 8-PWM?

These are relevant questions because the code can't just work on any PWM pins - I believe in the 8-PWM configuration requires complementary PWMs, like in 6-PWM? That means the complimentary signals have to come from the same timer. But they don't necessarily have to use CHx CHxN pins - it can also work with CHx CHy - but then there is no HW dead-time, only software. Also you can't mix and match hardware dead-time and software dead-time - it's either one or the other for all the pins. And you can't use CHxN on the high side, e.g. you can only use those when doing all HW dead-time.
So there are loads of complexities and constraints :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants