Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SASL bind #62

Merged
merged 10 commits into from
Oct 31, 2024
Merged

Add support for SASL bind #62

merged 10 commits into from
Oct 31, 2024

Conversation

manu0401
Copy link
Contributor

We introduce a ldap_sasl() method in Ldap and LdapMulti with an optionnal array of SASL options. A module that subclasses Ldap or Ldapmulti can use it instead of simple login().

This requires SASL bind support in Symfony, which has been merged in the 7.3 branch. SimpleSAMLphp uses Symfony 7.2. How should this ne handled? I can backport the patches for Symfony 7.2, but do we have a way to fold them in the simpleSAMLphp package?

We introduce a ldap_sasl() method in Ldap and LdapMulti with
an optionnal array of SASL options. A module that subclasses
Ldap or Ldapmulti can use it instead of simple login().

This requires SASL bind support in Symfony, which has been
merged in the 7.3 branch. SimpleSAMLphp uses Symfony 7.2.
How should this ne handled? I can backport the patches
for Symfony 7.2, but do we have a way to fold them in
the simpleSAMLphp package?
@tvdijen
Copy link
Member

tvdijen commented Oct 30, 2024

Hi @manu0401 !
There is no way to fold this into SimpleSAMLphp unless we upgrade to Symfony 7.x.
We're currently running Symfony 6.4 LTS right now (not 7.2 as you said), and we will wait until the next LTS is released in Nov 2025 before we do anything.
The reason for this is that we do not have the resources to keep up with Symfony's release cycle, so we stick with the LTS-versions.

@tvdijen tvdijen added the enhancement New feature or request label Oct 30, 2024
@manu0401
Copy link
Contributor Author

I could backport to Symfony 6.4, but I understand you would need to fork it, and include the forker version? Is it something that could be done?

@tvdijen
Copy link
Member

tvdijen commented Oct 30, 2024

No, we can't maintain forks of Symfony

@manu0401
Copy link
Contributor Author

I added tests for the new methods' presence in Symfony. That way:

  • if you use login() it works as without the change
  • if you use login_sasl() with older Symfony you get an exception
  • if you use login_sasl() with SASL-enabled Symfony, it works

In other words, it works as it did, it is ready for Symfony upgrade, and SASL will work with SimpleSAMLphp-bundled Symfony with SASL patches.

@tvdijen
Copy link
Member

tvdijen commented Oct 31, 2024

Excellent work @manu0401 ! You think you can fix the QA-issues?
I'll merge and tag a release immediately

Update: I took care of the code quality-issues myself

@tvdijen tvdijen merged commit b4b1fbd into simplesamlphp:master Oct 31, 2024
12 checks passed
@tvdijen
Copy link
Member

tvdijen commented Oct 31, 2024

Tagged v2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants