-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SASL bind #62
Conversation
We introduce a ldap_sasl() method in Ldap and LdapMulti with an optionnal array of SASL options. A module that subclasses Ldap or Ldapmulti can use it instead of simple login(). This requires SASL bind support in Symfony, which has been merged in the 7.3 branch. SimpleSAMLphp uses Symfony 7.2. How should this ne handled? I can backport the patches for Symfony 7.2, but do we have a way to fold them in the simpleSAMLphp package?
Hi @manu0401 ! |
I could backport to Symfony 6.4, but I understand you would need to fork it, and include the forker version? Is it something that could be done? |
No, we can't maintain forks of Symfony |
I added tests for the new methods' presence in Symfony. That way:
In other words, it works as it did, it is ready for Symfony upgrade, and SASL will work with SimpleSAMLphp-bundled Symfony with SASL patches. |
Excellent work @manu0401 ! Update: I took care of the code quality-issues myself |
Tagged v2.4.0 |
We introduce a ldap_sasl() method in Ldap and LdapMulti with an optionnal array of SASL options. A module that subclasses Ldap or Ldapmulti can use it instead of simple login().
This requires SASL bind support in Symfony, which has been merged in the 7.3 branch. SimpleSAMLphp uses Symfony 7.2. How should this ne handled? I can backport the patches for Symfony 7.2, but do we have a way to fold them in the simpleSAMLphp package?