removed unneeded commons-io dependency

refactored string into constants
simplesteph · Apr 30, 2017 · 9de09cc · 9de09cc
1 parent f607cc8
commit 9de09cc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/pom.xml b/pom.xml
@@ -27,12 +27,6 @@
             <version>${junit.version}</version>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>commons-io</groupId>
-            <artifactId>commons-io</artifactId>
-            <version>2.4</version>
-            <scope>test</scope>
-        </dependency>
         <!-- https://mvnrepository.com/artifact/org.slf4j/slf4j-log4j12 -->
         <dependency>
             <groupId>org.slf4j</groupId>

diff --git a/src/main/java/com/simplesteph/kafka/model/Issue.java b/src/main/java/com/simplesteph/kafka/model/Issue.java
@@ -405,12 +405,12 @@ public static Issue fromJson(JSONObject jsonObject) {
         issue.withState(jsonObject.getString(STATE_FIELD));
 
         // user is mandatory
-        User user = User.fromJson(jsonObject.getJSONObject("user"));
+        User user = User.fromJson(jsonObject.getJSONObject(USER_FIELD));
         issue.withUser(user);
 
         // pull request is an optional fields
-        if (jsonObject.has("pull_request")){
-            PullRequest pullRequest = PullRequest.fromJson(jsonObject.getJSONObject("pull_request"));
+        if (jsonObject.has(PR_FIELD)){
+            PullRequest pullRequest = PullRequest.fromJson(jsonObject.getJSONObject(PR_FIELD));
             issue.withPullRequest(pullRequest);
         }