test: use net.JoinHostPort instead of Sprintf

This fixes the linter warning: internal/upload/docker/docker_test.go:31:19: host:port in url should be constructed with net.JoinHostPort and not directly with fmt.Sprintf (nosprintfhostport)
simplesurance · Dec 13, 2023 · 3cf33cb · 3cf33cb
1 parent 9d2652c
commit 3cf33cb
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/internal/upload/docker/docker_test.go b/internal/upload/docker/docker_test.go
@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"encoding/base64"
 	"fmt"
+	"net"
 	"testing"
 
 	docker "github.com/fsouza/go-dockerclient"
@@ -28,7 +29,7 @@ func TestGetAuth(t *testing.T) {
 
 	const myRegistryHostname = "myregistry.com"
 	const myRegistryPort = dockerRegistryDefaultPort
-	myRegistryURL := fmt.Sprintf("https://%s:%s", myRegistryHostname, myRegistryPort)
+	myRegistryURL := fmt.Sprintf("https://%s", net.JoinHostPort(myRegistryHostname, myRegistryPort))
 	const myRegistryUser = "hugo"
 	const myRegistryPasswd = "hello"