Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-24424 all fields missing fields updates #233

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

bhtowles
Copy link
Contributor

TDL-24424 all fields missing fields updates. Add ads_insights stream to test, switch implementation to use MISSING_FIELDS, update missing fields to get test passing.

Description of change

(write a short description or paste a link to JIRA)

Manual QA steps

Risks

Rollback steps

  • revert this branch

@bhtowles bhtowles added the testing QA work. No src code changes. label Oct 26, 2023
Copy link
Contributor

@bhuvana-talend bhuvana-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Thanks for explaining the Missing fields and upsert fields

@bhtowles bhtowles merged commit d9f361e into master Oct 26, 2023
7 checks passed
@bhtowles bhtowles deleted the qa/all-fields-oct-2023 branch October 26, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing QA work. No src code changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants